View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001655 | SymmetricDS | Bug | public | 2014-03-27 14:41 | 2014-06-17 00:27 |
Reporter | cronjefourie | Assigned To | elong | ||
Priority | normal | ||||
Status | closed | Resolution | fixed | ||
Product Version | 3.5.17 | ||||
Target Version | 3.6.0 | Fixed in Version | 3.6.0 | ||
Summary | 0001655: host.bind.name has no effect when running stand-alone | ||||
Description | Setting the value host.bind.name in symmetric-server.properties has NO effect on the binding name. This makes it impossible to run the service on a specific IP when using standalone mode. | ||||
Steps To Reproduce | Install and config sym-ds as stand-alone system & windows service Set host.bind.name to a preferred IP Start service Service will bind to ALL IP's | ||||
Tags | No tags attached. | ||||
|
issue-1655.patch (2,562 bytes)
Index: symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricLauncher.java =================================================================== --- symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricLauncher.java (revision 8112) +++ symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricLauncher.java (working copy) @@ -25,6 +25,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.slf4j.MDC; + +import com.mysql.jdbc.StringUtils; /** * Launch the SymmetricDS engine as a stand alone client or server. @@ -196,8 +198,10 @@ } else { SymmetricWebServer webServer = new SymmetricWebServer(chooseWebDir(line, webDir), maxIdleTime, propertiesFile != null ? propertiesFile.getCanonicalPath() : null, - true, noNio, noDirectBuffer); - webServer.setHost(host); + true, noNio, noDirectBuffer); + if (!StringUtils.isNullOrEmpty(host)) { + webServer.setHost(host); + } webServer.setBasicAuthUsername(httpBasicAuthUser); webServer.setBasicAuthPassword(httpBasicAuthPassword); Index: symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricWebServer.java =================================================================== --- symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricWebServer.java (revision 8112) +++ symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricWebServer.java (working copy) @@ -382,7 +382,7 @@ connector.setHost(host); connector.setMaxIdleTime(maxIdleTime); connectors.add(connector); - log.info("About to start {} web server on port {}", name, port); + log.info(String.format("About to start %s web server on host:port %s:%s", name, host, port)); } if (mode.equals(Mode.HTTPS) || mode.equals(Mode.MIXED)) { ISecurityService securityService = SecurityServiceFactory.create(SecurityServiceType.SERVER, new TypedProperties(System.getProperties())); @@ -402,7 +402,7 @@ connector.setPort(securePort); connector.setHost(host); connectors.add(connector); - log.info("About to start SymmetricDS web server on secure port {}", securePort); + log.info(String.format("About to start SymmetricDS web server on secure host:port %s:%s", host,securePort)); } return connectors.toArray(new Connector[connectors.size()]); } |
|
I've created a patch issue-1655.patch to fix this problem, by correctly setting the host of the socket if it is supplied. |
SymmetricDS: master 29eaa199 2014-03-27 11:43:08 erilong Details Diff |
0001655: host.bind.name has no effect when running stand-alone |
Affected Issues 0001655 |
|
mod - symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricLauncher.java | Diff File | ||
mod - symmetric-server/src/main/java/org/jumpmind/symmetric/SymmetricWebServer.java | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2014-03-27 14:41 | cronjefourie | New Issue | |
2014-03-27 14:42 | cronjefourie | File Added: issue-1655.patch | |
2014-03-27 14:42 | cronjefourie | Note Added: 0000502 | |
2014-03-27 16:00 | Changeset attached | => SymmetricDS trunk r8113 | |
2014-03-27 19:23 | elong | Assigned To | => elong |
2014-03-27 19:23 | elong | Status | new => resolved |
2014-03-27 19:23 | elong | Fixed in Version | => 3.6.0 |
2014-03-27 19:23 | elong | Target Version | => 3.6.0 |
2014-03-27 19:24 | elong | Status | resolved => closed |
2014-03-27 19:24 | elong | Resolution | open => fixed |
2014-03-27 19:25 | admin | Status | closed => resolved |
2014-06-17 00:27 | chenson | Status | resolved => closed |
2015-07-31 01:49 | Changeset attached | => SymmetricDS master 29eaa199 |