View Issue Details

IDProjectCategoryView StatusLast Update
0002102SymmetricDSImprovementpublic2015-01-06 17:27
ReporterviliusAssigned Tochenson 
PrioritynormalSeveritytextReproducibilityalways
Status closedResolutionfixed 
Product Version3.7.0 
Target Version3.7.0Fixed in Version3.7.0 
Summary0002102: Remove double logging of exception messages to improve log readability
DescriptionChange occurrences of

"""
log.error(e.getMessage(), e);
"""

(for all log levels), which effectively logs the exception message twice to

"""
log.error("", e);
"""
Additional Informationhttps://sourceforge.net/p/symmetricds/discussion/739237/thread/92d13f56/
TagsNo tags attached.

Activities

vilius

2014-12-15 12:16

reporter  

double_ex_msg_logging.patch (27,792 bytes)
Index: symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java
===================================================================
--- symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java	(revision 9062)
+++ symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java	(working copy)
@@ -944,7 +944,7 @@
             platformColumn.setDecimalDigits(decimalDigits);
             column.addPlatformColumn(platformColumn);
         } catch (Exception ex) {
-            log.warn(ex.getMessage(), ex);
+            log.warn("", ex);
         }        
         
         if (columnSize == null) {
Index: symmetric-db/src/main/java/org/jumpmind/db/platform/mysql/MySqlDdlBuilder.java
===================================================================
--- symmetric-db/src/main/java/org/jumpmind/db/platform/mysql/MySqlDdlBuilder.java	(revision 9062)
+++ symmetric-db/src/main/java/org/jumpmind/db/platform/mysql/MySqlDdlBuilder.java	(working copy)
@@ -193,7 +193,7 @@
                     processColumnChange(sourceTable, targetTable, sourceColumn, targetColumn, ddl);
                     changeIt.remove();
                 } catch (CloneNotSupportedException e) {
-                    log.error(e.getMessage(), e);
+                    log.error("", e);
                 }
             }
         }
Index: symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java
===================================================================
--- symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java	(revision 9062)
+++ symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java	(working copy)
@@ -362,7 +362,7 @@
                     String valueTrimmed = FormatUtils.abbreviateForLogging(value);
                     log.error("Could not convert a value of {} for column {} of type {}",
                             new Object[] { valueTrimmed, column.getName(), column.getMappedType() });
-                    log.error(ex.getMessage(), ex);
+                    log.error("", ex);
                     throw new RuntimeException(ex);
                 }
             }
Index: symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractTest.java
===================================================================
--- symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractTest.java	(revision 9062)
+++ symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractTest.java	(working copy)
@@ -136,7 +136,7 @@
                 try {
                     webServer.stop();
                 } catch (Exception e) {
-                    log.error(e.getMessage(), e);
+                    log.error("", e);
                 }
             }
         }
Index: symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractIntegrationTest.java
===================================================================
--- symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractIntegrationTest.java	(revision 9062)
+++ symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractIntegrationTest.java	(working copy)
@@ -132,7 +132,7 @@
                 AbstractIntegrationTest.server = server;
             }
         } catch (Exception e) {
-            logger.error(e.getMessage(), e);
+            logger.error("", e);
             fail(e.getMessage());
         }
 
Index: symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricServlet.java
===================================================================
--- symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricServlet.java	(revision 9062)
+++ symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricServlet.java	(working copy)
@@ -229,7 +229,7 @@
                     "Error while processing {} request for externalId: {}, node: {} at {} ({}) with path: {}",
                     new Object[] { method, externalId, nodeId, address, hostName,
                             ServletUtils.normalizeRequestUri(req) });
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         } else {
             log.warn(
                     "Error while processing {} request for externalId: {}, node: {} at {} ({}).  The message is: {}",
Index: symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricEngineHolder.java
===================================================================
--- symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricEngineHolder.java	(revision 9062)
+++ symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricEngineHolder.java	(working copy)
@@ -231,7 +231,7 @@
             }
             return engine;
         } catch (Exception e) {
-            log.error(e.getMessage(), e);
+            log.error("", e);
             return null;
         }
     }
@@ -255,7 +255,7 @@
             try {
                 engines.get(engineName).stop();
             } catch (Exception e) {
-                log.error(e.getMessage(), e);
+                log.error("", e);
             }
             engines.remove(engineName);
         }
Index: symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java
===================================================================
--- symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java	(revision 9062)
+++ symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java	(working copy)
@@ -351,7 +351,7 @@
                     ArrayUtils.toString(row.toArray(table.getColumnNames())));
             if (continueOnError) {
                 if (debug) {
-                    log.info(ex.getMessage(), ex);
+                    log.info("", ex);
                 }
             } else {
                 throw ex;
@@ -379,7 +379,7 @@
                     ArrayUtils.toString(row.toArray(table.getColumnNames())));
             if (continueOnError) {
                 if (debug) {
-                    log.info(ex.getMessage(), ex);
+                    log.info("", ex);
                 }
             } else {
                 throw ex;
@@ -425,7 +425,7 @@
                     ArrayUtils.toString(row.toArray(table.getColumnNames())));
             if (continueOnError) {
                 if (debug) {
-                    log.info(ex.getMessage(), ex);
+                    log.info("", ex);
                 }
             } else {
                 throw ex;
Index: symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DataProcessor.java
===================================================================
--- symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DataProcessor.java	(revision 9062)
+++ symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DataProcessor.java	(working copy)
@@ -238,7 +238,7 @@
                 dataResource.close();
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
     }
 
Index: symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractServiceTest.java
===================================================================
--- symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractServiceTest.java	(revision 9062)
+++ symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractServiceTest.java	(working copy)
@@ -70,7 +70,7 @@
                     throw new IllegalStateException(cause);
                 }
             } catch (Exception ex) {
-                logger.error(ex.getMessage(), ex);
+                logger.error("", ex);
                 Assert.fail(ex.getMessage());
             }
             //setLoggingLevelForTest(old);
Index: symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractRouterServiceTest.java
===================================================================
--- symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractRouterServiceTest.java	(revision 9062)
+++ symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractRouterServiceTest.java	(working copy)
@@ -944,7 +944,7 @@
                 Assert.assertEquals(0, gap.getEndId() - gap.getStartId());
             }
         } catch (Exception ex) {
-            logger.error(ex.getMessage(), ex);
+            logger.error("", ex);
             throw ex;
         }
     }
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractSymmetricDialect.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractSymmetricDialect.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractSymmetricDialect.java	(working copy)
@@ -458,7 +458,7 @@
                 try {
                     database = merge(database, readDatabaseFromXml(extraTablesXml));
                 } catch (Exception ex) {
-                    log.error(ex.getMessage(), ex);
+                    log.error("", ex);
                 }
             }
             
@@ -626,7 +626,7 @@
                             tableName));
                 }
             } catch (SqlException ex) {
-                log.warn(ex.getMessage(), ex);
+                log.warn("", ex);
                 AppUtils.sleep(5000);
                 tryCount--;
             }
@@ -650,7 +650,7 @@
                 return System.currentTimeMillis();
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
             return System.currentTimeMillis();
         }
     }
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/transport/internal/InternalTransportManager.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/transport/internal/InternalTransportManager.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/transport/internal/InternalTransportManager.java	(working copy)
@@ -192,7 +192,7 @@
             }
             return HttpURLConnection.HTTP_OK;
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
             return -1;
         }
     }
@@ -212,7 +212,7 @@
                     ISymmetricEngine engine = getTargetEngine(url);
                     runnable.run(engine, is, os);
                 } catch (Exception e) {
-                    log.error(e.getMessage(), e);
+                    log.error("", e);
                 } finally {
                     IOUtils.closeQuietly(is);
                     IOUtils.closeQuietly(os);
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java	(working copy)
@@ -105,7 +105,7 @@
         try {
             execute();
         } catch (Throwable ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
     }
 
@@ -176,7 +176,7 @@
             processInfo.setStatus(Status.OK);
         } catch (Throwable ex) {
             processInfo.setStatus(Status.ERROR);
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         } finally {
             if (cursor != null) {
                 cursor.close();
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java	(working copy)
@@ -927,7 +927,7 @@
         } catch (RuntimeException ex) {
             log.error("Could not insert a data event: data_id={} batch_id={} router_id={}",
                     new Object[] { dataId, batchId, routerId });
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
             throw ex;
         }
     }
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java	(working copy)
@@ -146,7 +146,7 @@
                 readThread.shutdown();
                 readThread = null;
             } catch (Exception ex) {
-                log.error(ex.getMessage(), ex);
+                log.error("", ex);
             }
         }
     }
@@ -257,7 +257,7 @@
             }
 
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
 
     }
@@ -464,7 +464,7 @@
                 if (context != null) {
                     context.rollback();
                 }
-                log.error(e.getMessage(), e);
+                log.error("", e);
             } finally {
                 long totalTime = System.currentTimeMillis() - ts;
                 context.incrementStat(totalTime, ChannelRouterContext.STAT_ROUTE_TOTAL_TIME);
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java	(working copy)
@@ -113,7 +113,7 @@
                 log.warn("Did not run the data gap purge process because the cluster service has it locked");
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
         return rowsPurged;
     }
@@ -140,7 +140,7 @@
                 log.debug("Could not get a lock to run an outgoing purge");
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
         return rowsPurged;
     }
@@ -315,7 +315,7 @@
                 log.debug("Could not get a lock to run an incoming purge");
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
         return purgedRowCount;
     }
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java	(working copy)
@@ -312,7 +312,7 @@
                 log.error("Could not connect to the {} node's transport because of a bad URL: {}",
                         remote.getNodeId(), remote.getSyncUrl());
             } else {
-                log.error(e.getMessage(), e);
+                log.error("", e);
             }
             throw e;
         }
@@ -880,7 +880,7 @@
                     symmetricDialect.enableSyncTriggers(transaction);
                 }
             } catch (Exception ex) {
-                log.error(ex.getMessage(), ex);
+                log.error("", ex);
             }
         }
 
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/BandwidthService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/BandwidthService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/BandwidthService.java	(working copy)
@@ -56,7 +56,7 @@
         } catch (SocketTimeoutException e) {
             log.warn("Socket timeout while attempting to contact {}", syncUrl);
         } catch (Exception e) {
-            log.error(e.getMessage(), e);
+            log.error("", e);
         }
         return downloadSpeed;
 
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java	(working copy)
@@ -407,7 +407,7 @@
             } catch (ConnectionRejectedException ex) {
                 log.warn("The request to register was rejected by the server.  Either the server node is not started, the server is not configured properly or the registration url is incorrect");
             } catch (Exception e) {
-                log.error(e.getMessage(), e);
+                log.error("", e);
             }
 
             maxNumberOfAttempts--;
@@ -585,7 +585,7 @@
             } catch (ConnectionRejectedException ex) {
                 log.warn("The request to copy was rejected by the server.  Either the server node is not started, the server is not configured properly or the registration url is incorrect");
             } catch (Exception e) {
-                log.error(e.getMessage(), e);
+                log.error("", e);
             }
 
             maxNumberOfAttempts--;
Index: symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java
===================================================================
--- symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java	(revision 9062)
+++ symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java	(working copy)
@@ -449,7 +449,7 @@
                     platform.createDatabase(database, true, true);
                     loaded = true;
                 } catch (Exception e) {
-                    log.error(e.getMessage(), e);
+                    log.error("", e);
                 }
             }
         }
Index: symmetric-util/src/main/java/org/jumpmind/properties/DefaultParameterParser.java
===================================================================
--- symmetric-util/src/main/java/org/jumpmind/properties/DefaultParameterParser.java	(revision 9062)
+++ symmetric-util/src/main/java/org/jumpmind/properties/DefaultParameterParser.java	(working copy)
@@ -127,7 +127,7 @@
                 }
             }
         } catch (IOException e) {
-            log.error(e.getMessage(), e);
+            log.error("", e);
         }
         return metaData;
     }
Index: symmetric-util/src/main/java/org/jumpmind/properties/TypedProperties.java
===================================================================
--- symmetric-util/src/main/java/org/jumpmind/properties/TypedProperties.java	(revision 9062)
+++ symmetric-util/src/main/java/org/jumpmind/properties/TypedProperties.java	(working copy)
@@ -178,7 +178,7 @@
             }
             return objects;
         } catch (Exception ex) {
-            log.warn(ex.getMessage(), ex);
+            log.warn("", ex);
             return objects;
         }
     }
Index: symmetric-util/src/main/java/org/jumpmind/util/AppUtils.java
===================================================================
--- symmetric-util/src/main/java/org/jumpmind/util/AppUtils.java	(revision 9062)
+++ symmetric-util/src/main/java/org/jumpmind/util/AppUtils.java	(working copy)
@@ -102,7 +102,7 @@
                 }
 
             } catch (Exception ex) {
-                log.warn(ex.getMessage(), ex);
+                log.warn("", ex);
             }
         }
         return hostName;
@@ -115,7 +115,7 @@
             try {
                 portNumber = "31415";
             } catch (Exception ex) {
-                log.warn(ex.getMessage(), ex);
+                log.warn("", ex);
             }
         }
         return portNumber;
@@ -137,7 +137,7 @@
                     }
                 }
             } catch (Exception ex) {
-                log.warn(ex.getMessage(), ex);
+                log.warn("", ex);
             } finally {
             }
         }
@@ -146,7 +146,7 @@
             try {
                 ipAddress = InetAddress.getLocalHost().getHostAddress();
             } catch (UnknownHostException ex) {
-                log.warn(ex.getMessage(), ex);
+                log.warn("", ex);
                 ipAddress = "127.0.0.1";
             }
         }
Index: symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSqlSymmetricDialect.java
===================================================================
--- symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSqlSymmetricDialect.java	(revision 9062)
+++ symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSqlSymmetricDialect.java	(working copy)
@@ -127,7 +127,7 @@
             }
         } catch (Exception e) {            
             log.warn("Failed to disable lock escalation");
-            log.debug(e.getMessage(), e);
+            log.debug("", e);
         }
         return altered;
     }
Index: symmetric-client/src/main/java/org/jumpmind/symmetric/db/oracle/OracleSymmetricDialect.java
===================================================================
--- symmetric-client/src/main/java/org/jumpmind/symmetric/db/oracle/OracleSymmetricDialect.java	(revision 9062)
+++ symmetric-client/src/main/java/org/jumpmind/symmetric/db/oracle/OracleSymmetricDialect.java	(working copy)
@@ -296,7 +296,7 @@
                 date = DateUtils.parseDate(returnValue, new String[] { "MM/dd/yy HH:mm:ss" });
                 return date.getTime() < time;
             } catch (ParseException e) {
-                log.error(e.getMessage(),e);
+                log.error("", e);
                 return true;
             }
         } else {
Index: symmetric-client/src/main/java/org/jumpmind/symmetric/service/jmx/NodeManagementService.java
===================================================================
--- symmetric-client/src/main/java/org/jumpmind/symmetric/service/jmx/NodeManagementService.java	(revision 9062)
+++ symmetric-client/src/main/java/org/jumpmind/symmetric/service/jmx/NodeManagementService.java	(working copy)
@@ -83,7 +83,7 @@
                 return false;
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
             return false;
         }
     }
@@ -95,7 +95,7 @@
                 engine.stop();
             }
         } catch (Exception ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
     }
 
Index: symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java
===================================================================
--- symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java	(revision 9062)
+++ symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java	(working copy)
@@ -193,7 +193,7 @@
                 fileInfo.outputFileWriter.flush();
                 fileInfo.outputFileWriter.close();
             } catch (IOException e) {
-                logger.warn(e.getMessage(), e);
+                logger.warn("", e);
             }
         }
     }
@@ -204,7 +204,7 @@
             try {
                 fileInfo.outputFileWriter.close();
             } catch (IOException e) {
-                logger.warn(e.getMessage(), e);
+                logger.warn("", e);
             } finally {
                 FileUtils.deleteQuietly(fileInfo.outputFile);
             }
Index: symmetric-client/src/main/java/org/jumpmind/symmetric/job/AbstractJob.java
===================================================================
--- symmetric-client/src/main/java/org/jumpmind/symmetric/job/AbstractJob.java	(revision 9062)
+++ symmetric-client/src/main/java/org/jumpmind/symmetric/job/AbstractJob.java	(working copy)
@@ -210,7 +210,7 @@
                 }
             }
         } catch (final Throwable ex) {
-            log.error(ex.getMessage(), ex);
+            log.error("", ex);
         }
 
         return ran;
Index: symmetric-client/src/test/java/org/jumpmind/symmetric/test/TestSetupUtil.java
===================================================================
--- symmetric-client/src/test/java/org/jumpmind/symmetric/test/TestSetupUtil.java	(revision 9062)
+++ symmetric-client/src/test/java/org/jumpmind/symmetric/test/TestSetupUtil.java	(working copy)
@@ -119,7 +119,7 @@
                 logger.info("Removing client database files and creating directory.");
                 FileUtils.deleteDirectory(clientDbDir);
             } catch (IOException e) {
-                logger.error(e.getMessage(), e);
+                logger.error("", e);
             }
         }
         clientDbDir.mkdir();
@@ -129,7 +129,7 @@
                 logger.info("Removing root database files and creating directory.");
                 FileUtils.deleteDirectory(rootDbDir);
             } catch (IOException e) {
-                logger.error(e.getMessage(), e);
+                logger.error("", e);
             }
         }
         rootDbDir.mkdir();
Index: symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidJobManager.java
===================================================================
--- symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidJobManager.java	(revision 9062)
+++ symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidJobManager.java	(working copy)
@@ -126,7 +126,7 @@
                         try {
                             engine.route();
                         } catch (Throwable ex) {
-                            log.error(ex.getMessage(), ex);
+                            log.error("", ex);
                         } finally {
                             lastRouteTime = System.currentTimeMillis();
                         }
@@ -139,7 +139,7 @@
                             didWork = true;
                             engine.push();
                         } catch (Throwable ex) {
-                            log.error(ex.getMessage(), ex);
+                            log.error("", ex);
                         } finally {
                             lastPushTime = System.currentTimeMillis();
                         }
@@ -152,7 +152,7 @@
                             didWork = true;
                             engine.pull();
                         } catch (Throwable ex) {
-                            log.error(ex.getMessage(), ex);
+                            log.error("", ex);
                         } finally {
                             lastPullTime = System.currentTimeMillis();
                         }
@@ -165,7 +165,7 @@
                             didWork = true;
                             engine.heartbeat(false);
                         } catch (Throwable ex) {
-                            log.error(ex.getMessage(), ex);
+                            log.error("", ex);
                         } finally {
                             lastHeartbeatTime = System.currentTimeMillis();
                         }
@@ -178,7 +178,7 @@
                             didWork = true;
                             engine.purge();
                         } catch (Throwable ex) {
-                            log.error(ex.getMessage(), ex);
+                            log.error("", ex);
                         } finally {
                             lastPurgeTime = System.currentTimeMillis();
                         }

Related Changesets

SymmetricDS: master 71b47a76

2014-12-16 12:38:55

chenson

Details Diff
0002102: Remove double logging of exception messages to improve log readability
0002102
mod - symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidJobManager.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/db/mssql/MsSqlSymmetricDialect.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/db/oracle/OracleSymmetricDialect.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/job/AbstractJob.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/service/jmx/NodeManagementService.java Diff File
mod - symmetric-client/src/test/java/org/jumpmind/symmetric/test/TestSetupUtil.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractSymmetricDialect.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/BandwidthService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RouterService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/internal/InternalTransportManager.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractRouterServiceTest.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractServiceTest.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/platform/AbstractDatabasePlatform.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/platform/mysql/MySqlDdlBuilder.java Diff File
mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DataProcessor.java Diff File
mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java Diff File
mod - symmetric-jdbc/src/main/java/org/jumpmind/db/platform/AbstractJdbcDdlReader.java Diff File
mod - symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricEngineHolder.java Diff File
mod - symmetric-server/src/main/java/org/jumpmind/symmetric/web/SymmetricServlet.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractIntegrationTest.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/test/AbstractTest.java Diff File
mod - symmetric-util/src/main/java/org/jumpmind/properties/DefaultParameterParser.java Diff File
mod - symmetric-util/src/main/java/org/jumpmind/properties/TypedProperties.java Diff File
mod - symmetric-util/src/main/java/org/jumpmind/util/AppUtils.java Diff File

Issue History

Date Modified Username Field Change
2014-12-15 12:16 vilius New Issue
2014-12-15 12:16 vilius File Added: double_ex_msg_logging.patch
2014-12-16 12:39 chenson Product Version => 3.7.0
2014-12-16 12:39 chenson Fixed in Version => 3.7.0
2014-12-16 12:39 chenson Target Version => 3.7.0
2014-12-16 12:39 chenson Status new => resolved
2014-12-16 12:39 chenson Resolution open => fixed
2014-12-16 12:39 chenson Assigned To => chenson
2014-12-16 15:00 chenson Changeset attached => SymmetricDS trunk r9070
2015-01-06 17:27 chenson Status resolved => closed
2015-07-30 21:49 chenson Changeset attached => SymmetricDS master 71b47a76