View Issue Details

IDProjectCategoryView StatusLast Update
0002392SymmetricDSBugpublic2015-09-13 18:00
ReporterchensonAssigned Tochenson 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.7.20 
Target Version3.7.21Fixed in Version3.7.21 
Summary0002392: SqlScriptReader has a bug where if multiline literals in a statement have a comment at the end of the line, the comment is lost
DescriptionSqlScriptReader has a bug where if multiline literals in a statement have a comment at the end of the line, the comment is lost

For example:

insert into test (col) values('<!--
<test></test>
-->');

will result in a col values of:

<!
-->
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

SymmetricDS: 3.7 ef3ff0f8

2015-09-11 16:07:27

chenson

Details Diff
0002392: SqlScriptReader has a bug where if multiline literals in a
statement have a comment at the end of the line, the comment is lost

0002392
mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java Diff File
mod - symmetric-db/src/test/java/org/jumpmind/db/sql/SqlScriptReaderTest.java Diff File
mod - symmetric-db/src/test/resources/test-script-1.sql Diff File

SymmetricDS: 3.7 8612ded7

2015-09-13 16:04:04

chenson

Details Diff
0002392 - most of the time you don't want block comments to be stripped
out (hints). Default the functionality to not strip them out.

0002392
mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java Diff File
mod - symmetric-db/src/test/java/org/jumpmind/db/sql/SqlScriptReaderTest.java Diff File
mod - symmetric-db/src/test/resources/test-script-1.sql Diff File

SymmetricDS: 3.7 71228b86

2015-09-13 17:37:03

chenson

Details Diff
0002392: SqlScriptReader has a bug where if multiline literals in a
statement have a comment at the end of the line, the comment is lost

0002392
mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java Diff File
mod - symmetric-db/src/test/java/org/jumpmind/db/sql/SqlScriptReaderTest.java Diff File
mod - symmetric-db/src/test/resources/test-script-1.sql Diff File

Issue History

Date Modified Username Field Change
2015-09-11 14:11 chenson New Issue
2015-09-11 14:11 chenson Status new => assigned
2015-09-11 14:11 chenson Assigned To => chenson
2015-09-11 16:15 chenson Status assigned => closed
2015-09-11 16:15 chenson Resolution open => fixed
2015-09-11 16:15 chenson Fixed in Version => 3.7.21
2015-09-11 17:00 chenson Changeset attached => SymmetricDS 3.7 ef3ff0f8
2015-09-13 17:00 chenson Changeset attached => SymmetricDS 3.7 8612ded7
2015-09-13 18:00 chenson Changeset attached => SymmetricDS 3.7 71228b86