View Issue Details

IDProjectCategoryView StatusLast Update
0002781SymmetricDSImprovementpublic2016-09-16 09:00
ReportergatokinoAssigned Toelong 
PrioritylowSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product Version3.8.2 
Target Version3.8.4Fixed in Version3.8.4 
Summary0002781: Loop is continuing even when condition is meet
Descriptioncode source of class

org.jumpmind.symmetric.service.impl.DataExtractorService

there are 2 for loops line 1235 and 1273

for (OutgoingBatch outgoingBatch : batches) {
  if (outgoingBatch.getStatus() != Status.OK) {
    areBatchesOk = false;
  }
}

a "break;" after the "areBatchesOk = false;" statement can improuve the code.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

SymmetricDS: 3.8 89de283a

2016-09-09 16:48:22

admin

Details Diff
0002781: Loop is continuing even when condition is meet
0002781
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java Diff File

Issue History

Date Modified Username Field Change
2016-09-09 06:02 gatokino New Issue
2016-09-09 16:48 elong Assigned To => elong
2016-09-09 16:48 elong Status new => assigned
2016-09-09 16:48 elong Status assigned => resolved
2016-09-09 16:48 elong Resolution open => fixed
2016-09-09 16:48 elong Fixed in Version => 3.8.4
2016-09-09 16:48 elong Target Version => 3.8.4
2016-09-09 17:00 admin Changeset attached => SymmetricDS 3.8 89de283a
2016-09-16 09:00 admin Status resolved => closed