View Issue Details

IDProjectCategoryView StatusLast Update
0003859SymmetricDS ProImprovementpublic2019-01-17 15:55
ReporterpmarzulloAssigned Topmarzullo 
Status resolvedResolutionfixed 
Product Version3.10.0 
Target Version3.10.0Fixed in Version3.10.0 
Summary0003859: NodeService.findNode(...) (cached versus non-cached), where to use correct one
DescriptionI looked at the calls to NodeService.findNode(...) (the non-cached versions, 40 of them) and summarized which ones can use the cached version.
My logic was, if it had anything to do with changing the node, or registering the node, or reloading the node, it should call the non-cached version, otherwise use the cached version.

Let me know what you think.

        buttonClick(ClickEvent event)
            Should call (cached) findNode(String, boolean)
        refresh(ISymmetricEngine engine)
            Should call (cached) findNode(String, boolean)
TagsNo tags attached.



2019-01-17 15:55

developer   ~0001383

code changes made as suggested in issue description

Issue History

Date Modified Username Field Change
2019-01-17 15:50 pmarzullo New Issue
2019-01-17 15:50 pmarzullo Status new => assigned
2019-01-17 15:50 pmarzullo Assigned To => pmarzullo
2019-01-17 15:55 pmarzullo Status assigned => resolved
2019-01-17 15:55 pmarzullo Resolution open => fixed
2019-01-17 15:55 pmarzullo Fixed in Version => 3.10.0
2019-01-17 15:55 pmarzullo Note Added: 0001383