View Issue Details

IDProjectCategoryView StatusLast Update
0003968SymmetricDSImprovementpublic2019-05-20 10:00
ReporterjaredfreesAssigned Tojaredfrees 
Prioritynormal 
Status resolvedResolutionfixed 
Product Version3.9.21 
Target Version3.10.3Fixed in Version 
Summary0003968: Inner classes should be made static for efficiency and to reduce coupling
DescriptionDiscussion here: https://github.com/JumpMind/symmetric-ds/pull/98
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Related Changesets

SymmetricDS: 3.9 ddac0b8d

2019-05-16 11:59:33

DAVECRAMER


Committer: jfrees Details Diff
0003968: Inner classes should be made static for efficiency and to reduce coupling (#98)

* make all inner classes static

* more static inner classes

0003968
mod - symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidSymmetricEngine.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/DbCompare.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/stage/SimpleStagingDataWriter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ConfigurationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ExtensionService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/FileSyncService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/IncomingBatchService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/MonitorService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OfflinePullService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OutgoingBatchService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/SequenceService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/ConcurrentConnectionManager.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/file/FileIncomingTransport.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/http/HttpBandwidthUrlSelector.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/route/DataGapRouteReaderTest.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractDataExtractorServiceTest.java Diff File
mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvReader.java Diff File
mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvWriter.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java Diff File
mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java Diff File
mod - symmetric-io/src/test/java/org/jumpmind/symmetric/io/AbstractWriterTest.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherDataRouterTest.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherFilterTest.java Diff File
mod - symmetric-sqlexplorer/src/main/java/org/jumpmind/vaadin/ui/sqlexplorer/QueryPanel.java Diff File
rm - symmetric-sqlexplorer/src/main/webapp/VAADIN/themes/sqlexplorer/addons.scss Diff File
mod - symmetric-util/src/main/java/org/jumpmind/util/SimpleClassCompiler.java Diff File
mod - symmetric-util/src/test/java/org/jumpmind/util/SymRollingFileAppenderTest.java Diff File
mod - symmetric-wrapper/src/main/java/org/jumpmind/symmetric/wrapper/WrapperConfig.java Diff File

SymmetricDS: 3.10 956ef137

2019-05-16 11:59:33

DAVECRAMER


Committer: jfrees Details Diff
0003968: Inner classes should be made static for efficiency and to reduce coupling (#98)

* make all inner classes static

* more static inner classes

(cherry picked from commit ddac0b8d69cb12ffaa6306b04203e56a9bacf240)

0003968
mod - symmetric-android/src/main/java/org/jumpmind/symmetric/android/AndroidSymmetricEngine.java Diff File
mod - symmetric-client/src/main/java/org/jumpmind/symmetric/io/FtpDataWriter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/db/AbstractTriggerTemplate.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/DbCompare.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/io/stage/SimpleStagingDataWriter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ConfigurationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataExtractorService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/ExtensionService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/FileSyncService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/IncomingBatchService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/MonitorService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeCommunicationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/NodeService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OfflinePullService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/OutgoingBatchService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/PurgeService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/SequenceService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TransformService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/ConcurrentConnectionManager.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/file/FileIncomingTransport.java Diff File
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/transport/http/HttpBandwidthUrlSelector.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/route/DataGapRouteReaderTest.java Diff File
mod - symmetric-core/src/test/java/org/jumpmind/symmetric/service/impl/AbstractDataExtractorServiceTest.java Diff File
mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvReader.java Diff File
mod - symmetric-csv/src/main/java/org/jumpmind/symmetric/csv/CsvWriter.java Diff File
mod - symmetric-db/src/main/java/org/jumpmind/db/sql/SqlScriptReader.java Diff File
mod - symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/DbFill.java Diff File
mod - symmetric-io/src/test/java/org/jumpmind/symmetric/io/AbstractWriterTest.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherDataRouterTest.java Diff File
mod - symmetric-server/src/test/java/org/jumpmind/symmetric/integrate/XmlPublisherFilterTest.java Diff File
mod - symmetric-sqlexplorer/src/main/java/org/jumpmind/vaadin/ui/sqlexplorer/QueryPanel.java Diff File
rm - symmetric-sqlexplorer/src/main/webapp/VAADIN/themes/sqlexplorer/addons.scss Diff File
mod - symmetric-util/src/main/java/org/jumpmind/util/SimpleClassCompiler.java Diff File
mod - symmetric-util/src/test/java/org/jumpmind/util/SymRollingFileAppenderTest.java Diff File
mod - symmetric-wrapper/src/main/java/org/jumpmind/symmetric/wrapper/WrapperConfig.java Diff File

SymmetricDS: 3.10 68d5dfa5

2019-05-16 16:55:15

jfrees

Details Diff
0003968: Fix visibility issue
0003968
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java Diff File

SymmetricDS: 3.9 150eaca9

2019-05-20 09:06:00

jfrees

Details Diff
0003968: Fix visibility issue
0003968
mod - symmetric-core/src/main/java/org/jumpmind/symmetric/route/ColumnMatchDataRouter.java Diff File

Issue History

Date Modified Username Field Change
2019-05-16 11:58 jaredfrees New Issue
2019-05-16 11:58 jaredfrees Status new => assigned
2019-05-16 11:58 jaredfrees Assigned To => jaredfrees
2019-05-16 12:00 jfrees Changeset attached => SymmetricDS 3.9 ddac0b8d
2019-05-16 13:00 jfrees Changeset attached => SymmetricDS 3.10 956ef137
2019-05-16 14:17 jaredfrees Status assigned => resolved
2019-05-16 14:17 jaredfrees Resolution open => fixed
2019-05-16 17:00 jfrees Changeset attached => SymmetricDS 3.10 68d5dfa5
2019-05-20 10:00 jfrees Changeset attached => SymmetricDS 3.9 150eaca9