View Issue Details

IDProjectCategoryView StatusLast Update
0001973SymmetricDSBugpublic2014-09-17 18:01
ReporterviliusAssigned Toelong 
Prioritynormal 
Status closedResolutionfixed 
Product Version3.6.7 
Target VersionFixed in Version3.6.8 
Summary0001973: Use LSB-compliant dependency in init script
Descriptioninit script declares a dependency on 'networking' in the INIT INFO header. This should work on Debian-based systems as /etc/init.d/networking provides a 'networking' facility. However, there's nothing providing such a facility on a CentOS system (so likely on other RedHat-based systems as well).

LSB defines the '$network' system facility [1], which should work fine on any LSB-compliant systems, including Debian, CentOS, openSUSE. I propose using that instead in the attached patch.


[1] http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/facilname.html
TagsNo tags attached.

Activities

vilius

2014-09-17 05:38

reporter  

init_script_dependency_lsb_compliance.patch (585 bytes)
Index: symmetric-wrapper/src/main/resources/symmetricds.initd
===================================================================
--- symmetric-wrapper/src/main/resources/symmetricds.initd	(revision 8703)
+++ symmetric-wrapper/src/main/resources/symmetricds.initd	(working copy)
@@ -7,8 +7,8 @@
 
 ### BEGIN INIT INFO
 # Provides:          ${wrapper.name}
-# Required-Start:    networking
-# Required-Stop:     networking
+# Required-Start:    $network
+# Required-Stop:     $network
 # Default-Start:     2 3 5
 # Default-Stop:      0 1 6
 # Short-Description: ${wrapper.displayname}

Related Changesets

SymmetricDS: master 79e71bc1

2014-09-17 08:23:10

erilong

Details Diff
0001973: Use LSB-compliant dependency in init script
0001973
mod - symmetric-wrapper/src/main/resources/symmetricds.initd Diff File

Issue History

Date Modified Username Field Change
2014-09-17 05:38 vilius New Issue
2014-09-17 05:38 vilius File Added: init_script_dependency_lsb_compliance.patch
2014-09-17 08:25 elong Assigned To => elong
2014-09-17 08:25 elong Status new => assigned
2014-09-17 08:26 elong Status assigned => resolved
2014-09-17 08:26 elong Fixed in Version => 3.6.8
2014-09-17 08:26 elong Resolution open => fixed
2014-09-17 09:00 Changeset attached => SymmetricDS trunk r8704
2014-09-17 09:00 Changeset attached => SymmetricDS 3.6 r8705
2014-09-17 18:01 chenson Status resolved => closed
2015-07-30 21:49 Changeset attached => SymmetricDS master 79e71bc1