View Issue Details

IDProjectCategoryView StatusLast Update
0004309SymmetricDSBugpublic2020-03-17 14:43
ReporterelongAssigned Toelong 
Prioritynormal 
Status closedResolutionfixed 
Product Version3.9.18 
Target Version3.11.7Fixed in Version3.11.7 
Summary0004309: batchError incorrectly checks create time
DescriptionIn the MonitorTypeBatchError.check(monitor) method we add count of error batches to the result object basing on the error batch create time:
-------------------------------------------------------------------------------------------------------------------------
int batchErrorMinutes = (int) (System.currentTimeMillis() - batch.getCreateTime().getTime()) / 60000;
            if (batchErrorMinutes >= monitor.getThreshold()) {
.....
 outgoingErrorCount++;
.....
}
event.setValue(outgoingErrorCount + incomingErrorCount);
-------------------------------------------------------------------------------------------------------------------------


but after that in MonitorService.updateMonitor(........) we add to the sym_monitor_event the which value is more than monitor. The value here is the count of error batches.
-------------------------------------------------------------------------------------------------------------------------
} else if (eventValue.getValue() >= monitor.getThreshold()) {
.....
......
.....
}
-------------------------------------------------------------------------------------------------------------------------

Is it expected behavior that first we compare time in minutes with threshold and after that, we compare count of events with threshold?
Steps To ReproduceNo need, see code. MonitorService and MonitorTypeBatchError classes
TagsNo tags attached.

Relationships

related to 0004286 closedelong batchError monitor threshold logic 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2020-03-11 13:41 elong New Issue
2020-03-11 13:41 elong Status new => assigned
2020-03-11 13:41 elong Assigned To => elong
2020-03-11 13:41 elong Issue generated from: 0004286
2020-03-11 13:41 elong Relationship added related to 0004286
2020-03-11 13:41 elong Status assigned => resolved
2020-03-11 13:41 elong Resolution open => fixed
2020-03-11 13:41 elong Fixed in Version => 3.11.7
2020-03-17 14:43 admin Status resolved => closed